improve: code structure

services/redis-service.ts

@@ -13,10 +13,10 @@ const redisUrl = process.env.REDIS_URL || 'redis://localhost:6379';
 let redisClient: RedisClient | null = null;
 
 try {
-    redisClient = new RedisClient(redisUrl);
-    logger.info('Redis client initialized. Connection will be established on first command.');
+  redisClient = new RedisClient(redisUrl);
+  logger.info('Redis client initialized. Connection will be established on first command.');
 } catch (error) {
-    logger.error('Failed to initialize Redis client:', error);
+  logger.error('Failed to initialize Redis client:', error);
 }
 
 /**
@@ -25,17 +25,17 @@ try {
  * @returns Parsed JSON object or null if not found/error
  */
 export async function getActivityData(activityId: string): Promise<any | null> {
-    if (!redisClient) {
-        logger.warn('Redis client not available, skipping getActivityData');
-        return null;
-    }
-    try {
-        const data = await redisClient.get(`${ACTIVITY_KEY_PREFIX}${activityId}`);
-        return data ? JSON.parse(data) : null;
-    } catch (err) {
-        logger.error(`Error getting activity ${activityId} from Redis:`, err);
-        return null;
-    }
+  if (!redisClient) {
+    logger.warn('Redis client not available, skipping getActivityData');
+    return null;
+  }
+  try {
+    const data = await redisClient.get(`${ACTIVITY_KEY_PREFIX}${activityId}`);
+    return data ? JSON.parse(data) : null;
+  } catch (err) {
+    logger.error(`Error getting activity ${activityId} from Redis:`, err);
+    return null;
+  }
 }
 
 /**
@@ -44,15 +44,15 @@ export async function getActivityData(activityId: string): Promise<any | null> {
  * @param data - The activity data object
  */
 export async function setActivityData(activityId: string, data: any): Promise<void> {
-    if (!redisClient) {
-        logger.warn('Redis client not available, skipping setActivityData');
-        return;
-    }
-    try {
-        await redisClient.set(`${ACTIVITY_KEY_PREFIX}${activityId}`, JSON.stringify(data));
-    } catch (err) {
-        logger.error(`Error setting activity ${activityId} in Redis:`, err);
-    }
+  if (!redisClient) {
+    logger.warn('Redis client not available, skipping setActivityData');
+    return;
+  }
+  try {
+    await redisClient.set(`${ACTIVITY_KEY_PREFIX}${activityId}`, JSON.stringify(data));
+  } catch (err) {
+    logger.error(`Error setting activity ${activityId} in Redis:`, err);
+  }
 }
 
 /**
@@ -60,17 +60,17 @@ export async function setActivityData(activityId: string, data: any): Promise<vo
  * @returns Parsed JSON object or null if not found/error
  */
 export async function getStaffData(): Promise<any | null> {
-    if (!redisClient) {
-        logger.warn('Redis client not available, skipping getStaffData');
-        return null;
-    }
-    try {
-        const data = await redisClient.get(STAFF_KEY);
-        return data ? JSON.parse(data) : null;
-    } catch (err) {
-        logger.error('Error getting staff data from Redis:', err);
-        return null;
-    }
+  if (!redisClient) {
+    logger.warn('Redis client not available, skipping getStaffData');
+    return null;
+  }
+  try {
+    const data = await redisClient.get(STAFF_KEY);
+    return data ? JSON.parse(data) : null;
+  } catch (err) {
+    logger.error('Error getting staff data from Redis:', err);
+    return null;
+  }
 }
 
 /**
@@ -78,15 +78,15 @@ export async function getStaffData(): Promise<any | null> {
  * @param data - The staff data object
  */
 export async function setStaffData(data: any): Promise<void> {
-    if (!redisClient) {
-        logger.warn('Redis client not available, skipping setStaffData');
-        return;
-    }
-    try {
-        await redisClient.set(STAFF_KEY, JSON.stringify(data));
-    } catch (err) {
-        logger.error('Error setting staff data in Redis:', err);
-    }
+  if (!redisClient) {
+    logger.warn('Redis client not available, skipping setStaffData');
+    return;
+  }
+  try {
+    await redisClient.set(STAFF_KEY, JSON.stringify(data));
+  } catch (err) {
+    logger.error('Error setting staff data in Redis:', err);
+  }
 }
 
 /**
@@ -95,39 +95,39 @@ export async function setStaffData(data: any): Promise<void> {
  * @returns An array of keys
  */
 export async function getAllActivityKeys(): Promise<string[]> {
-    if (!redisClient) {
-        logger.warn('Redis client not available, skipping getAllActivityKeys');
-        return [];
-    }
-    try {
-        // Using raw SCAN command since Bun's RedisClient doesn't have a scan method
-        const keys: string[] = [];
-        let cursor = '0';
-        
-        do {
-            // Use send method to execute raw Redis commands
-            const result = await redisClient.send('SCAN', [
-                cursor, 
-                'MATCH', 
-                `${ACTIVITY_KEY_PREFIX}*`, 
-                'COUNT', 
-                '100'
-            ]);
-            
-            cursor = result[0];
-            const foundKeys = result[1] || [];
-            
-            // Add the found keys to our array
-            keys.push(...foundKeys);
-            
-        } while (cursor !== '0');
-        
-        logger.info(`Found ${keys.length} activity keys in Redis using SCAN.`);
-        return keys;
-    } catch (err) {
-        logger.error('Error getting all activity keys from Redis using SCAN:', err);
-        return []; // Return empty array on error
-    }
+  if (!redisClient) {
+    logger.warn('Redis client not available, skipping getAllActivityKeys');
+    return [];
+  }
+  try {
+    // Using raw SCAN command since Bun's RedisClient doesn't have a scan method
+    const keys: string[] = [];
+    let cursor = '0';
+    
+    do {
+      // Use send method to execute raw Redis commands
+      const result = await redisClient.send('SCAN', [
+        cursor, 
+        'MATCH', 
+        `${ACTIVITY_KEY_PREFIX}*`, 
+        'COUNT', 
+        '100'
+      ]);
+      
+      cursor = result[0];
+      const foundKeys = result[1] || [];
+      
+      // Add the found keys to our array
+      keys.push(...foundKeys);
+      
+    } while (cursor !== '0');
+    
+    logger.info(`Found ${keys.length} activity keys in Redis using SCAN.`);
+    return keys;
+  } catch (err) {
+    logger.error('Error getting all activity keys from Redis using SCAN:', err);
+    return []; // Return empty array on error
+  }
 }
 
 /**
@@ -135,15 +135,15 @@ export async function getAllActivityKeys(): Promise<string[]> {
  * @returns The Redis client or null if not initialized
  */
 export function getRedisClient(): RedisClient | null {
-    return redisClient;
+  return redisClient;
 }
 
 /**
  * Closes the Redis connection.
  */
 export async function closeRedisConnection(): Promise<void> {
-    if (redisClient) {
-        redisClient.close();
-        logger.info('Redis connection closed.');
-    }
+  if (redisClient) {
+    redisClient.close();
+    logger.info('Redis connection closed.');
+  }
 }